feat: Update the bindings and add the default message sync url #284
+49
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Aug 7, 2024
library/src/main/java/README.md
Outdated
| @@ -12,5 +12,6 @@ Kotlin code emitted by the `bindings_ffi` crate in [libxmtp](https://github.com/ | |||
| 4. Navigate to the [latest release](https://github.com/xmtp/libxmtp/releases) once the action completes | |||
| 5. Download the `LibXMTPKotlinFFI.zip` assets | |||
| 6. Unzip and then copy the jniLibs to `xmtp-android/library/src/main/jniLibs` | |||
| 7. NOTE: sometimes the library name gets updated and will cause failures the library name must be `uniffi_xmtpv3` not `xmtpv3` -- search for `findLibraryName` and make sure the correct name is returned. | |||
There was a problem hiding this comment.
I don't know why when we bumped to uniffi version 28 that this started renaming the library. I did a deep dive today through the docs and don't see any reason why this would be happening https://mozilla.github.io/uniffi-rs/latest/kotlin/configuration.html. This is a work around until we can invest more time in it to figure it out.
There was a problem hiding this comment.
Re- lint failure, not sure if we should maybe re-add this line as well:
There was a problem hiding this comment.
Good call that one came back too. 😭
alexrisch
reviewed
Aug 7, 2024
nplasterer
changed the title
neekolas
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default message sync url and bumps to the latest rust.