feat: New V3 Identity #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
May 22, 2024
nplasterer
commented
May 22, 2024
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
neekolas
reviewed
May 22, 2024
neekolas
reviewed
May 22, 2024
library/src/main/java/org/xmtp/android/library/Conversations.kt
Outdated
Show resolved
Hide resolved
neekolas
reviewed
May 22, 2024
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
nplasterer
commented
May 22, 2024
nplasterer
commented
May 24, 2024
| } catch (e: ClassNotFoundException) { | ||
| // … otherwise, fallback to the JNA cleaner. | ||
| UniffiJnaCleaner() | ||
| } |
There was a problem hiding this comment.
@cameronvoell maybe it's just a linter bugger seems to have the fallback here...
There was a problem hiding this comment.
Which would catch the error if the create() function is called
There was a problem hiding this comment.
yea I think you're right 👍
neekolas
reviewed
May 27, 2024
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
nplasterer
commented
May 27, 2024
Comment on lines
+37
to
+46
| <issue | ||
| id="SimpleDateFormat" | ||
| message="To get local formatting use `getDateInstance()`, `getDateTimeInstance()`, or `getTimeInstance()`, or use `new SimpleDateFormat(String template, Locale locale)` with for example `Locale.US` for ASCII dates." | ||
| errorLine1=" val formatter = SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss 'GMT'")" | ||
| errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> | ||
| <location | ||
| file="src/main/java/org/xmtp/android/library/messages/Signature.kt" | ||
| line="53" | ||
| column="21"/> | ||
| </issue> |
There was a problem hiding this comment.
@alexrisch is there a reason you need to use the simple date format? I'm just leaving it as a lint issue we can ignore but would be good to understand why we need it.
There was a problem hiding this comment.
No solid reason vs any other way to get the same date format
neekolas
reviewed
May 27, 2024
alexrisch
reviewed
May 28, 2024
library/src/main/java/org/xmtp/android/library/libxmtp/MessageV3.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new V3 Identity for Groups. Gets rid of
accountAddressin favor ofinboxId.Will add support for smart contract wallets in a follow up PR.
cc @neekolas @cameronvoell