Group message delivery status #232
Merged
+138
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Apr 18, 2024
| @@ -12,6 +13,7 @@ data class DecodedMessage( | |||
| var encodedContent: Content.EncodedContent, | |||
| var senderAddress: String, | |||
| var sent: Date, | |||
| var deliveryStatus: MessageDeliveryStatus = MessageDeliveryStatus.PUBLISHED | |||
There was a problem hiding this comment.
V2 messages default to published.
| @@ -330,9 +331,11 @@ class GroupTest { | |||
| fun testCanSendMessageToGroup() { | |||
| val group = runBlocking { boClient.conversations.newGroup(listOf(alix.walletAddress)) } | |||
| runBlocking { group.send("howdy") } | |||
| runBlocking { group.send("gm") } | |||
| val messageId = runBlocking { group.send("gm") } | |||
| runBlocking { group.sync() } | |||
| assertEquals(group.messages().first().body, "gm") | |||
There was a problem hiding this comment.
I see that the group.send("gm") was here prior and now grabbing the messageId. However, I'm confused by how the subsequent equality test passed in the first place. Wouldn't this be the second message in the group? Asking to understand rather than request changes. 🙂
There was a problem hiding this comment.
The messages come in descending order by default since the last message is the first message you want to see.
There was a problem hiding this comment.
Oh wow! That's great to know. Thanks for sharing.
zombieobject
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of xmtp/libxmtp#516