feat: streaming and threading improvements #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
changed the title
richardhuaaa
approved these changes
Mar 13, 2024
| @@ -169,31 +169,31 @@ sealed class Conversation { | |||
| } | |||
| } | |||
|
|
|||
| fun send(prepared: PreparedMessage): String { | |||
| suspend fun send(prepared: PreparedMessage): String { | |||
There was a problem hiding this comment.
Is this a breaking change, or will existing code continue to work (albeit no longer waiting for the publish to complete)? Not in this PR, but long-term do we have any thoughts on splitting out the two conversation types, and allowing the API's to be different across the two to maintain backwards compatibility?
There was a problem hiding this comment.
Technically it's a breaking change if anyone was using send outside of a thread. As you can see there are no changes to the example app in this PR because my example app was already calling send in a thread so I honestly think this change may be unnoticeable to most integrators as they were likely sending it asynchronously anyways.
zombieobject
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a major overhaul of how we are doing async calls in Android. Switching from
runBlockingtosuspendfunctions for all send message functionality to help prevent deadlocking during streaming.