Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function to delete database #187

Merged
merged 3 commits into from
Feb 23, 2024
Merged

feat: add function to delete database #187

merged 3 commits into from
Feb 23, 2024

Conversation

nplasterer
Copy link
Contributor

Method to delete database that can be called on wallet disconnection.

@nplasterer nplasterer self-assigned this Feb 22, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 22, 2024 06:46
Comment on lines 163 to 164
libXMTPClient: FfiXmtpClient? = null,
dbPath: String = ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having to store the dbPath like this is it something the FfiXmtpClient could expose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could keep track of that and expose it. We have the info

@nplasterer nplasterer enabled auto-merge (squash) February 23, 2024 15:19
@nplasterer nplasterer merged commit 5da219a into main Feb 23, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/delete-database branch February 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants