Group Chat Streaming #166
Group Chat Streaming #166
Conversation
This reverts commit 8998d13.
…into np/group-conversations
This reverts commit 76bfcc7.
…roup-streaming
| fun streamDecryptedMessages(): Flow<DecryptedMessage> = callbackFlow { | ||
| val messageCallback = object : FfiMessageCallback { | ||
| override fun onMessage(message: FfiMessage) { | ||
| trySend(decrypt(Message(client, message))) |
There was a problem hiding this comment.
I think we want to refer to what you're doing in here as decoding rather than decrypting. The messages all get decrypted in libxmtp.
There was a problem hiding this comment.
So we have two streaming methods one for decoding and one for decrypting. We need this stream decrypted messages for React Native custom content types. @nakajima could speak more to it.
Since Groups are conforming to the current Conversation model I have to use these methods. Once we do the refactor to Groups Dms and Conversation parent we might be able to get rid of some of these things.
But to break as little of the existing flow as possible. This is needed.
There was a problem hiding this comment.
What is the intended difference between a DecryptedMessage and a DecodedMessage? When I trace the method calls from both streaming methods, they seem to produce the same result (they both return something with a field called encodedContent that is set to EncodedContent.parseFrom(libXMTPMessage.content))
There was a problem hiding this comment.
I don't think there is going to be any difference in the V3 world but again I didn't follow as closely to the reasoning for custom contentTypes. I found this for context xmtp/xmtp-ios#196
| fun streamDecryptedMessages(): Flow<DecryptedMessage> = callbackFlow { | ||
| val messageCallback = object : FfiMessageCallback { | ||
| override fun onMessage(message: FfiMessage) { | ||
| trySend(decrypt(Message(client, message))) |
There was a problem hiding this comment.
What is the intended difference between a DecryptedMessage and a DecodedMessage? When I trace the method calls from both streaming methods, they seem to produce the same result (they both return something with a field called encodedContent that is set to EncodedContent.parseFrom(libXMTPMessage.content))
This adds the streaming components of group chat