Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add catch to listBatchDecryptedMessages method #161

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix: add catch to listBatchDecryptedMessages method #161

merged 3 commits into from
Jan 24, 2024

Conversation

kele-leanes
Copy link
Contributor

Closes xmtp/xmtp-react-native#218.

This update adds a try-catch block to the listBatchDecryptedMessages method, improving error handling.

@kele-leanes kele-leanes self-assigned this Jan 24, 2024
@kele-leanes kele-leanes requested a review from a team as a code owner January 24, 2024 13:03
@nplasterer
Copy link
Contributor

I bet this change should also be made to listBatchMessages as well.

@kele-leanes
Copy link
Contributor Author

I wonder if this change is necessary on listBatchMessages since decodeOrNull is already catching the possible error

@nplasterer
Copy link
Contributor

Ahh nice catch I'll roll back my addition!

@nplasterer nplasterer merged commit 3e94c70 into main Jan 24, 2024
4 of 5 checks passed
@nplasterer nplasterer deleted the kele/fix-list-batch-decrypted branch January 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees

@kele-leanes kele-leanes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadBatchMessages Fails on Android with bad topic
2 participants
@kele-leanes @nplasterer