fix: Improve performance list method #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Jan 17, 2024
library/src/main/java/org/xmtp/android/library/ConversationV2.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/org/xmtp/android/library/ConversationV2.kt
Outdated
Show resolved
Hide resolved
library/src/androidTest/java/org/xmtp/android/library/ConversationsTest.kt
Outdated
Show resolved
Hide resolved
nplasterer
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Addressing the concerns raised in issue #130, this pull request enhances the pagination functionality for the list method. The key improvement involves introducing a new optional parameter,
createdAt, which can be set when a conversation is created. This parameter is subsequently utilized in theimportToTopicmethod to establish a reference point, enabling the retrieval of the most recent conversations from that specific date. Incorporating this enhancement significantly contributes to optimizing the request time for improved overall performance.