Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet connect v2 #134

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Wallet connect v2 #134

merged 11 commits into from
Nov 15, 2023

Conversation

Babak-gh
Copy link
Contributor

Wallet Connect V2 implementation using WallectConnect Android Core and WalletConnectModal

Proposed Implementation for #121

Babak-gh added 11 commits November 8, 2023 17:06
@Babak-gh
add WalletConnect v2 core and WalletConnectModal libraries
ed16675
@Babak-gh
add Navigation Component in ConnectWalletActivity because of WalletCo…
125bde5 
…nnectModal integration
@Babak-gh
remove a unnecessary line in ConnectWalletFragment from prev commit
fd27c5e
@Babak-gh
Create application class and basic Wallet Connect V2 and WalletConnec…
3787ee2 
…tModal Configurations
@Babak-gh
create Chains.kt enum for WC v2 integration and make a default Ethere…
7b290ea 
…um_Main chain in it
@Babak-gh
add ic_ethereum.xml file as chain icon
da4e316
@Babak-gh
create DappDelegate.kt for receiving asynchronously updates sent from…
db11b8a 
… the Wallet
@Babak-gh
create WalletConnectV2Account.kt to make xmtp SDK with WC v2
728e919
@Babak-gh
add connect with WalletConnectModal in ConnectWalletFragment
9d5bbb1
@Babak-gh
remove walletConnectKit library and replace the wallet connect button…
91e2af3 
… with outlined material button
@Babak-gh
replacing suspendCoroutine with callbackFlow for fixing double resume…
8ecc29e 
… problem
@Babak-gh Babak-gh requested a review from a team as a code owner November 12, 2023 02:56
@Babak-gh Babak-gh mentioned this pull request Nov 12, 2023
Closed
nplasterer
nplasterer approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I wasn't able to get it working with Rainbow Wallet but sometimes Rainbow can be a little funny. It worked okay with Metamask. 👍

@Babak-gh
Copy link
Contributor Author

This looks good to me. I wasn't able to get it working with Rainbow Wallet but sometimes Rainbow can be a little funny. It worked okay with Metamask. 👍

Thank you @nplasterer, There should be a small change in defaultMethods to properly work with Rainbow. Apparently, the Rainbow wallet does not accept all four main Eth methods as default. Two of them should be passed to Rainbow as optionalNameSpaces. I would be happy to make the changes if I have time next week.

@nplasterer nplasterer merged commit c260ec3 into xmtp:main Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Babak-gh @nplasterer