fix: Performance Issues on Buffer allocation

Fix buffer allocation/deallocation causing slow downs Added buffer pool and ability to pass buffer
xmtp · Apr 16, 2024 · 491e025 · 491e025
1 parent f0f702f
commit 491e025
Show file tree

Hide file tree

Showing 4 changed files with 296 additions and 12 deletions.
diff --git a/library/src/androidTest/java/org/xmtp/android/library/ContactsTest.kt b/library/src/androidTest/java/org/xmtp/android/library/ContactsTest.kt
@@ -5,6 +5,8 @@ import kotlinx.coroutines.runBlocking
 import org.junit.Assert.assertEquals
 import org.junit.Test
 import org.junit.runner.RunWith
+import org.xmtp.android.library.messages.PrivateKey
+import org.xmtp.android.library.messages.PrivateKeyBuilder
 import org.xmtp.android.library.messages.walletAddress
 
 @RunWith(AndroidJUnit4::class)
@@ -69,4 +71,23 @@ class ContactsTest {
         result = contacts.isDenied(fixtures.alice.walletAddress)
         assert(result)
     }
+
+    @Test
+    fun testHehehe() {
+        val privateKeyData = listOf(0x08, 0x36, 0x20, 0x0f, 0xfa, 0xfa, 0x17, 0xa3, 0xcb, 0x8b, 0x54, 0xf2, 0x2d, 0x6a, 0xfa, 0x60, 0xb1, 0x3d, 0xa4, 0x87, 0x26, 0x54, 0x32, 0x41, 0xad, 0xc5, 0xc2, 0x50, 0xdb, 0xb0, 0xe0, 0xcd)
+            .map { it.toByte() }
+            .toByteArray()
+        // Use hardcoded privateKey
+        val privateKey = PrivateKeyBuilder.buildFromPrivateKeyData(privateKeyData)
+        val privateKeyBuilder = PrivateKeyBuilder(privateKey)
+        val options = ClientOptions()
+        val client = Client().create(account = privateKeyBuilder, options = options)
+        val startTime = System.currentTimeMillis()
+
+        runBlocking { client.contacts.refreshConsentList()}
+        val endTime = System.currentTimeMillis()
+        val duration = endTime - startTime
+        println("Time to execute block: $duration ms")
+
+    }
 }
diff --git a/library/src/main/java/org/xmtp/android/library/Contacts.kt b/library/src/main/java/org/xmtp/android/library/Contacts.kt
@@ -1,11 +1,13 @@
 package org.xmtp.android.library
 
+import RustBufferPool
 import com.google.protobuf.kotlin.toByteStringUtf8
 import kotlinx.coroutines.runBlocking
 import org.xmtp.android.library.messages.ContactBundle
 import org.xmtp.android.library.messages.ContactBundleBuilder
 import org.xmtp.android.library.messages.EnvelopeBuilder
 import org.xmtp.android.library.messages.Pagination
+import org.xmtp.android.library.messages.PagingInfoSortDirection
 import org.xmtp.android.library.messages.Topic
 import org.xmtp.android.library.messages.walletAddress
 import org.xmtp.proto.message.api.v1.MessageApiOuterClass
@@ -65,6 +67,7 @@ class ConsentList(
     @OptIn(ExperimentalUnsignedTypes::class)
     suspend fun load(): List<ConsentListEntry> {
         val newDate = Date()
+
         val envelopes =
             client.apiClient.envelopes(
                 Topic.preferenceList(identifier).description,
@@ -76,22 +79,22 @@ class ConsentList(
             )
 
         lastFetched = newDate
+        val bufferPool = RustBufferPool(bufferSize = 36, poolSize = envelopes.size)
         val preferences: MutableList<PrivatePreferencesAction> = mutableListOf()
         for (envelope in envelopes) {
             val payload =
                 uniffi.xmtpv3.userPreferencesDecrypt(
                     publicKey.toByteArray(),
                     privateKey.toByteArray(),
                     envelope.message.toByteArray(),
+                    bufferPool
                 )
-
             preferences.add(
                 PrivatePreferencesAction.parseFrom(
                     payload.toUByteArray().toByteArray(),
                 )
             )
         }
-
         preferences.iterator().forEach { preference ->
             preference.allowAddress?.walletAddressesList?.forEach { address ->
                 allow(address)
@@ -106,7 +109,6 @@ class ConsentList(
                 denyGroup(groupId.toByteArray())
             }
         }
-
         return entries.values.toList()
     }
 

diff --git a/library/src/main/java/org/xmtp/android/library/RustBufferPool.kt b/library/src/main/java/org/xmtp/android/library/RustBufferPool.kt
@@ -0,0 +1,25 @@
+import uniffi.xmtpv3.RustBuffer
+
+class RustBufferPool(private val bufferSize: Int, private val poolSize: Int) {
+    private val buffers = Array(poolSize) { RustBuffer.alloc(bufferSize) }
+    private val available = BooleanArray(poolSize) { true }
+
+    @Synchronized
+    fun borrowBuffer(): RustBuffer.ByValue {
+        val index = available.indexOfFirst { it }
+        if (index == -1) {
+            throw RuntimeException("No available buffers in the pool")
+        }
+        available[index] = false
+        return buffers[index]
+    }
+
+    @Synchronized
+    fun returnBuffer(buffer: RustBuffer.ByValue) {
+        val index = buffers.indexOf(buffer)
+        if (index == -1) {
+            throw IllegalArgumentException("Buffer not from this pool")
+        }
+        available[index] = true
+    }
+}