Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 18.18.0 for provenance support #26

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Upgrade to node 18.18.0 for provenance support #26

merged 3 commits into from
Feb 12, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Feb 12, 2024

publishing with provenance requires npm 9.5+, which is not available in node 18.14.0. this PR upgrades node to 18.18.0, which provides npm 9.8.1.

i'm specifically not updating to node 18.19.0 because that version requires some due diligence to confirm compatibility with the XMTP JS SDK.

this PR also manually updates the package version in package.json. this is due to a local test publish, which doesn't work with provenance.

the next version to publish is 1.3.5. the previous versions without provenance have been unpublished.

@rygine rygine requested a review from a team February 12, 2024 23:09
Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: 96d085b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@xmtp/snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snap-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 11:18pm

@rygine rygine merged commit ed49679 into main Feb 12, 2024
9 checks passed
@rygine rygine deleted the rygine/take3 branch February 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants