feat: rename last_seen to depends_on and remove unimplemented MLS (#240)

* feat: rename last_seen to depends_on and remove unimplemented MLS * fix: remove unused response types
xmtp · Jan 23, 2025 · 9c2c26c · 9c2c26c
1 parent e295b46
commit 9c2c26c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 35 deletions.
diff --git a/proto/mls_validation/v1/service.proto b/proto/mls_validation/v1/service.proto
@@ -10,9 +10,6 @@ option go_package = "github.com/xmtp/proto/v3/go/mls_validation/v1";
 
 // RPCs for the new MLS API
 service ValidationApi {
-  // Validates and parses a batch of key packages and returns relevant details
-  rpc ValidateKeyPackages(ValidateKeyPackagesRequest) returns (ValidateKeyPackagesResponse) {}
-
   // Validates and parses a group message and returns relevant details
   rpc ValidateGroupMessages(ValidateGroupMessagesRequest) returns (ValidateGroupMessagesResponse) {}
 
@@ -23,12 +20,8 @@ service ValidationApi {
   // whether an InboxId <> InstallationPublicKey pair is really valid.
   rpc ValidateInboxIdKeyPackages(ValidateKeyPackagesRequest) returns (ValidateInboxIdKeyPackagesResponse) {}
 
-  // Validate an InboxID Key Package
-  // need public key possibly
-  rpc ValidateInboxIds(ValidateInboxIdsRequest) returns (ValidateInboxIdsResponse) {}
-
   // Verifies smart contracts
-  // This request is proxied from the node, so we'll reuse those messgaes.
+  // This request is proxied from the node, so we'll reuse those messages.
   rpc VerifySmartContractWalletSignatures(
     xmtp.identity.api.v1.VerifySmartContractWalletSignaturesRequest
   )  returns (
@@ -121,29 +114,4 @@ message GetAssociationStateRequest {
 message GetAssociationStateResponse {
   xmtp.identity.associations.AssociationState association_state = 1;
   xmtp.identity.associations.AssociationStateDiff state_diff = 2;
-}
-
-// Request to validate an InboxID with the backend service. Ensures an Inbox Id <> Installation key are valid.
-message ValidateInboxIdsRequest {
-  // a single validation request
-  message ValidationRequest {
-    xmtp.identity.MlsCredential credential = 1;
-    bytes installation_public_key = 2;
-    repeated xmtp.identity.associations.IdentityUpdate identity_updates = 3;
-  }
-
-  // list of validation requests
-  repeated ValidationRequest requests = 1;
-}
-
-// Response to ValidateInboxIdRequest
-message ValidateInboxIdsResponse {
-  // a single validation response
-  message ValidationResponse {
-    bool is_ok = 1;
-    string error_message = 2;
-    string inbox_id = 3;
-  }
-  // List of validation responses
-  repeated ValidationResponse responses = 1;
-}
+}
diff --git a/proto/xmtpv4/envelopes/envelopes.proto b/proto/xmtpv4/envelopes/envelopes.proto
@@ -18,7 +18,7 @@ message Cursor {
 message AuthenticatedData {
   uint32 target_originator = 1;
   bytes target_topic = 2;
-  Cursor last_seen = 3;
+  Cursor depends_on = 3;
 }
 
 message ClientEnvelope {