Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete private key for last resort KP. #8

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

Bren2010
Copy link

No description provided.

@Bren2010 Bren2010 force-pushed the brendan/deleting-lr branch from 182174b to 57d2a60 Compare December 30, 2023 03:43
@@ -41,11 +40,7 @@ pub use public_group::*;
pub(crate) use core_group::create_commit_params::*;
#[cfg(any(feature = "test-utils", test))]
pub(crate) mod tests;
#[cfg(any(feature = "test-utils", test))]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these features?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. Now that I'm running the repo locally I see the same warnings. Going to merge this so that I can pick up the fixes in my branch.

Copy link

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@neekolas neekolas merged commit 9c7d5cb into xmtp:main Jan 5, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants