Repro missing epochs #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was trying to reproduce the issue we've been seeing with OpenMLS where the
max_past_epochsflag was set to 3, but messages from even 1 previous epoch were failing with anAeadError.Your existing test for past epoch secrets passes so long as there is an in-memory group instance that is being updated. But if you attempt to load the group from storage before processing the message the
MessageSecretsStorehas nopast_tree_epochsavailable and fails to decrypt with anAeadError.I'm assuming we just need to write the
MessageSecretsto the storage provider after they have been updated, which I did in the last commit in this branch and the test starts passing again. If you remove the changes toprocess.rsyou will see the test failing with anAeadError