Update to Latest OpenMLS #803
workspace
6 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 6 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.0 (aedd173a2 2024-03-17)
- cargo 1.77.0 (3fe68eabf 2024-02-29)
- clippy 0.1.77 (aedd173 2024-03-17)
Annotations
Check warning on line 77 in xmtp_mls/src/groups/subscriptions.rs
github-actions / workspace
redundant closure
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:77:13
|
77 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 59 in xmtp_api_grpc/src/auth_token.rs
github-actions / workspace
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> xmtp_api_grpc/src/auth_token.rs:59:9
|
58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
| ---------------------------------------------------------------------------------- unnecessary `let` binding
59 | token_base64
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
58 ~
59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes)
|
Check warning on line 391 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 387 in xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 2934 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2934:86
|
2934 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 1334 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default