Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead endpoints #963

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove dead endpoints #963

merged 1 commit into from
Aug 15, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 14, 2024

AI Assisted Summary

TL;DR

Removed deprecated MLS API methods and updated related functionality.

What changed?

  • Removed register_installation method from XmtpMlsClient trait and its implementations.
  • Removed get_identity_updates method from XmtpMlsClient trait and its implementations.
  • Removed related types and imports for these deprecated methods.
  • Updated tests to reflect these changes.

How to test?

  1. Ensure all existing tests pass after removing the deprecated methods.
  2. Verify that any code previously using register_installation now uses upload_key_package instead.
  3. Check that no code is relying on the removed get_identity_updates functionality.

Why make this change?

This change is part of an effort to streamline the MLS API by removing deprecated methods. The register_installation method has been replaced by upload_key_package, and get_identity_updates is no longer needed. Removing these methods simplifies the API, reduces maintenance overhead, and ensures that clients are using the most up-to-date methods for interacting with the MLS system.


Copy link
Contributor Author

neekolas commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on Graphite Graphite

@neekolas neekolas marked this pull request as ready for review August 14, 2024 23:01
@neekolas neekolas requested a review from a team as a code owner August 14, 2024 23:02
@neekolas neekolas force-pushed the 08-13-remove_dead_endpoints branch 3 times, most recently from b197800 to 0bec95d Compare August 15, 2024 00:15
Copy link
Contributor Author

neekolas commented Aug 15, 2024

Merge activity

  • Aug 14, 5:32 PM PDT: @neekolas started a stack merge that includes this pull request via Graphite.
  • Aug 14, 5:35 PM PDT: Graphite rebased this pull request as part of a merge.
  • Aug 14, 5:41 PM PDT: @neekolas merged this pull request with Graphite.
  • Aug 27, 10:34 AM PDT: @neekolas started a stack merge that includes this pull request via Graphite.

@neekolas neekolas changed the base branch from 08-13-upload_key_package_before_publishing_identity_updates to graphite-base/963 August 15, 2024 00:33
@neekolas neekolas changed the base branch from graphite-base/963 to main August 15, 2024 00:33
@neekolas neekolas force-pushed the 08-13-remove_dead_endpoints branch from 0bec95d to 17ab6e7 Compare August 15, 2024 00:34
@neekolas neekolas merged commit 8b47df3 into main Aug 15, 2024
8 checks passed
@neekolas neekolas deleted the 08-13-remove_dead_endpoints branch August 15, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants