-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm Feature Branch #959
Merged
Merged
Wasm Feature Branch #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions Ported Co-authored-by: Ry Racherbaumer <[email protected]>
* statement stream * fix lifetimes on load query * execute returning count * transaction manager * cleanup
* fix diesel function registration * query building works * try insert with orml * compile with sqlite default fix * compile but still ahve static lifetimes * fix unimplemented traits * ORM compiles! * some cleanup, setup tracing in wasm for test * readme * upgrade wa-sqlite version * temp DebugQuery to help with debugging * make debug query unsafe * progress on statement issue * progress for destructor order * logs/fix async drop for BoundStatement * remove task spawn for statementfactory
* use official sqlite bindings * PORTED * can establish conn * getters/setters * constant from JS workaround * r2d2 connection * add custom allocator for faster memory * memory optimization, tests * clean up dependencies * clean * workflow * readme * dep pruning * readme change * readme
insipx
force-pushed
the
wasm-backend
branch
4 times, most recently
from
August 26, 2024 22:14
2187e91
to
68132b2
Compare
* organize wasm tests so they all run * make test organization much better, fix tests * fix workflow file
remove rollup plugin typescript organize JS into one folder
* fix bind blob * try to repro last compiler error * UpdateAndFetchResults * remove unused * workaround for insert_with_default * clippy
* compile xmtp_id and xmtp_mls to wasm32 * remove `native` features * remove unsafe & dup trait * annotate all tests with wasm-bindgen-test for wasm32 * xmtp_mls tests compile for wasm32 * dont create a new file for database in wasm32 * fix compile for bindings_wasm * pin to wasm-bindgen 0.2.92 * fix wasm-bindgen-test version
Sorry about the conflicts I think these are from my dms branch. 😬 |
insipx
force-pushed
the
wasm-backend
branch
3 times, most recently
from
October 15, 2024 20:10
84ddb35
to
fdcd2f2
Compare
insipx
force-pushed
the
wasm-backend
branch
2 times, most recently
from
October 15, 2024 20:20
3bb09d6
to
d8763de
Compare
nplasterer
approved these changes
Oct 16, 2024
codabrink
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking #942
closes #940 #941 #1038 #1034 #1104
EncryptedMessageStore
into traits & exposes a type alias depending on compile targetStreamHandles
into traits & exposes type alias depending on compile target./dev/lint-rust
scriptScopedGroupClient
held onMlsGroup
Client
as a field toMlsGroup
MlsGroup
accesses client methods throughScopedGroupClient
. This keepsthe distinction between
MlsGroup
andClient
clear (while also erasing type parameters), while opening it up tofuture refactors where we pull MlsGroup further away from client. (The subset of functions
MlsGroup
relies on fromClient
is actually rather smallsrc/groups/scoped_client.rs
)Much of this PR is changing attributes to account for webassembly (tokio-test vs wasm_bindgen::test, etc.)
Some more interesting bits to pay attention to:
encrypted_store/mod.rs
,encrypted_store/native.rs
,encrypted_store/wasm.rs
,groups/scoped_client.rs
andstream_handles.rs
. Some smaller changes tosubscriptions.rs
encrypted_store/mod.rs
, however the current way keeps the details well away from the Client or any code using the store. From the outside, it looks like nothing really changed.the patch dependency for
openssl-sys
was never being applied, (latest kotlin build for affected target):We have an openssl dependency for sqlite. after bringing all crates into the workspace, I was able to pin it:
It might be better to remove this pin entirely. We haven't been using it at all up until now, and pinning to an older openssl version feels wrong
vs main: