Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unsigned Identity Updates #620

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Apr 5, 2024

tl;dr

Adds a new UnsignedIdentityUpdate struct and unsigned variations of all the identity actions.

Why

We need this in two places:

  1. When deserializing protos to build an IdentityUpdate, we need to get the full signature text before we can properly build the signatures on each IdentityAction
  2. When creating a new IdentityUpdate the signature text requires the full set of actions in the update. So, we need to create the full IdentityUpdate in some form, gather the necessary signatures, and then turn it into the final format.

Copy link
Contributor Author

neekolas commented Apr 5, 2024

@neekolas neekolas marked this pull request as ready for review April 5, 2024 20:19
@neekolas neekolas requested a review from a team as a code owner April 5, 2024 20:19
@neekolas neekolas force-pushed the 04-05-add_unsigned_identity_updates branch from f92a4e8 to ab88b8f Compare April 5, 2024 20:20
@neekolas neekolas force-pushed the 04-04-association_history_processing_pt._2 branch from 1068a6b to 095ddb7 Compare April 6, 2024 00:04
Base automatically changed from 04-04-association_history_processing_pt._2 to main April 6, 2024 00:09
@neekolas neekolas force-pushed the 04-05-add_unsigned_identity_updates branch from ab88b8f to 63ef357 Compare April 7, 2024 19:33
@neekolas neekolas merged commit 7d6ef20 into main Apr 8, 2024
14 checks passed
Copy link
Contributor Author

neekolas commented Apr 8, 2024

Merge activity

@neekolas neekolas deleted the 04-05-add_unsigned_identity_updates branch April 8, 2024 16:09
@37ng 37ng mentioned this pull request Apr 10, 2024
@neekolas neekolas mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants