Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Latest OpenMLS #596

Merged
merged 18 commits into from
Mar 30, 2024
Merged

Update to Latest OpenMLS #596

merged 18 commits into from
Mar 30, 2024

Conversation

zombieobject
Copy link
Contributor

No description provided.

@zombieobject zombieobject self-assigned this Mar 26, 2024
@zombieobject zombieobject requested a review from a team March 26, 2024 23:17
neekolas
neekolas approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Thanks for powering through all these changes

@zombieobject
Copy link
Contributor Author

This is looking great. Thanks for powering through all these changes

I pushed a change to aggregate_member_list to ensure the error is propagated. The change is in 4d04bf67.

@zombieobject zombieobject requested a review from neekolas March 27, 2024 00:09
@zombieobject zombieobject added the on hold don't merge label Mar 28, 2024
@zombieobject
Copy link
Contributor Author

Placing on hold until I resolve the test failures.

@zombieobject
Copy link
Contributor Author

@neekolas Wow! Thank you kindly! I will spend time tomorrow digging into why this resolves the issue, but for now am super grateful for the contribution. 🫶🏼

@zombieobject zombieobject merged commit 8158f1b into main Mar 30, 2024
7 checks passed
@zombieobject zombieobject deleted the em/openmls-update branch March 30, 2024 04:04
@zombieobject
Copy link
Contributor Author

zombieobject commented Apr 1, 2024 •
edited
Loading

The use of .into() to go from BasicCredential -> OpenMLSCredential was an interesting solution to that problem. It makes complete sense the more that I think about it. My test stub to serialized and then deserialize the KeyPackage passed because I was creating the credentials using BasicCredential.

Fun stuff! Glad I had a chance to review that and thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas Awaiting requested review from neekolas

Assignees

@zombieobject zombieobject

Labels
on hold don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieobject @neekolas @tuddman