-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xmtp_xid
#591
Add xmtp_xid
#591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree we'll want to avoid a circular dependency. Think we can just copy as needed for now, and then only import from xmtp_mls
and delete the xmtp_mls
code once this is ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to rename xmtp_xid
to xmtp_id
since x represents xmtp
Sounds reasonable to me. It's weird enough that we are prefixing all of our stuff with the company name, we don't need to do it twice |
xmtp_xid
closes Scaffold new identity crate in libxmtp #588xmtp_mls
and related cratesnot really sure how much we need here so I just copied a very minimum of the
Identity
struct fromxmtp_mls
We probably want to reduce dependency on
xmtp_mls
as much as possible so we don't have a circular dependency, which implies also importingGrantMessagingAccessAssociation
. This may make more sense to be apart of #589 & the trait. We can potentially do something to the effect of:This will be clearer for me once I play around with the trait in 589 a bit