Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmtp_xid #591

Merged
merged 14 commits into from
Mar 25, 2024
Merged

Add xmtp_xid #591

merged 14 commits into from
Mar 25, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Mar 25, 2024

not really sure how much we need here so I just copied a very minimum of the Identity struct from xmtp_mls

We probably want to reduce dependency on xmtp_mls as much as possible so we don't have a circular dependency, which implies also importing GrantMessagingAccessAssociation. This may make more sense to be apart of #589 & the trait. We can potentially do something to the effect of:

  • decouple the 'association text' and EOA signing stuff
  • refactor messaging associations to be just EOA signature credential
  • implement new trait from XIP for these structs
    This will be clearer for me once I play around with the trait in 589 a bit

@insipx insipx marked this pull request as ready for review March 25, 2024 18:18
@insipx insipx requested review from a team, neekolas, 37ng and richardhuaaa March 25, 2024 18:18
xmtp_xid/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we'll want to avoid a circular dependency. Think we can just copy as needed for now, and then only import from xmtp_mls and delete the xmtp_mls code once this is ready

Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to rename xmtp_xid to xmtp_id since x represents xmtp

Copy link
Contributor

Sounds reasonable to me. It's weird enough that we are prefixing all of our stuff with the company name, we don't need to do it twice

@insipx insipx merged commit d0bcb73 into main Mar 25, 2024
7 checks passed
@insipx insipx deleted the insipx/identity-scaffold branch March 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold new identity crate in libxmtp
3 participants