-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt staticlib #433
Merged
Merged
Attempt staticlib #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
Merged
* Correct order in swiftlocal makefile * Added github action for adding zipped xcframework to github release on tag action * Run on branch commits instead of tags * Updated tag name to not begin with refs * Run swift local only needs to copy over source now * fix tag name, add license to release zip artifact * Add step for calculating checksum for release description * Fix SHA command and check LICENSE is copied as expected * Updated to only fire from manual workflow dispatch for now
This was referenced Jan 29, 2024
nakajima
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our swift bindings from dynamic lib (
.dylib
) to static lib (.a
) files.We're also adding a GitHub action that publishes swift bindings with the following directory structure to a Release artifact:
test-swift-bindings-ecb15b7/LibXMTPSwiftFFI.zip
contentsA demo of the released artifact can be seen here: https://github.com/xmtp/libxmtp/releases/tag/test-swift-bindings-ecb15b7
The release artifact zip folder will be referenced from our libxmtp-swift repository so that it can simulatenously publish to
Swift Package Manager
, andCocoapods
.Before this PR is merged, we would like to validate the setup against
xmtp-ios
andxmtp-react-native
repos. This testing can be done via the following three PRs: