Add find_groups method #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
requested review from
a team,
insipx and
richardhuaaa
and removed request for
a team
richardhuaaa
approved these changes
Nov 9, 2023
| @@ -94,6 +94,25 @@ where | |||
| Ok(group) | |||
| } | |||
|
|
|||
| pub fn find_groups( | |||
There was a problem hiding this comment.
Can we put this directly on the Group struct, with &Client as an argument? Same with create_group(). Would prefer not to have every DB-related method replicated on the Client class
There was a problem hiding this comment.
I think in the FFI world it's going to make life easier to have all the group administration (list, create) live on the Client that we return to the native SDK. That way they don't have to deal with a bunch of different foreign object types and passing around references.
We could still do that mapping in the bindings, but it's messier. How about we leave it for now and we can always move things around later if we decide that it isn't as ergonomic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MlsGroupinstancescreated_at_nstime on the group instance itself, so that callers can use their latest returned group as a starting time for future queries.