Implement post-commit actions #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
commented
Nov 9, 2023
| } | ||
| } | ||
| } | ||
| let deleter: &mut dyn Delete<StoredGroupIntent, Key = i32> = conn; |
There was a problem hiding this comment.
I had to do some gymnastics to make the Delete trait work now that we have multiple structs implementing it. Now that it requires disambiguation it's...not beautiful. Maybe there's some better way to tell the compiler which model we're deleting, or maybe we should rethink the trait to be explicitly generic.
There was a problem hiding this comment.
p. sure we can use Identifier trait for this, and remove the associated type, ref #314
insipx
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary