-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
312: introduce remote container development environment #313
Conversation
0469a15
to
c78f0ed
Compare
I discussed this change with @insipx to ensure the workflow is correct. All checks and tests are passing. All code changes address existing formatting issues because cargo fmt is currently not checked by the ci. Check is now required as of this PR. |
Added Node 20.9.0 toolchain for yarn and npm |
I like the docker image + but adding FMT to the current workflow is better. As far as speed for 1 vs the other I'm probably not the one to know In general I am for reproducible environments, so like the docker container and think it will make it easier to onboard devs in the future + have an easy way to get an environment up for example if we ever have a |
Can we include this in the README for future devs? And we mean the Dev Containers extension right? And is it correct to say that this is optional? The alternative is to configure your environment yourself? |
72673b3
to
8179dc4
Compare
- devcontainer - tasks.json - github ci-image workflow - fmt and fix fmt errors - include Node 20.9.0 toolchain - review feedback, remove lint flow, README.md
8179dc4
to
d903888
Compare
closes #312