Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

312: introduce remote container development environment #313

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jac18281828
Copy link
Contributor

@jac18281828 jac18281828 commented Nov 3, 2023

closes #312

  • introduces a development container with cargo and rust
  • check code and rust fmt
  • fix format issues currently committed on main
  • tasks.json, GitHub workflow, support files etc.

@jac18281828 jac18281828 self-assigned this Nov 3, 2023
@jac18281828 jac18281828 changed the title 312: introduce remote container development environment *NOT READY TO MERGE* 312: introduce remote container development environment Nov 6, 2023
@jac18281828
Copy link
Contributor Author

I discussed this change with @insipx to ensure the workflow is correct. All checks and tests are passing. All code changes address existing formatting issues because cargo fmt is currently not checked by the ci. Check is now required as of this PR.

@jac18281828 jac18281828 marked this pull request as ready for review November 6, 2023 19:09
@jac18281828 jac18281828 requested a review from a team November 6, 2023 19:09
@jac18281828 jac18281828 added enhancement New feature or request good first issue Good for newcomers labels Nov 6, 2023
@jac18281828
Copy link
Contributor Author

Added Node 20.9.0 toolchain for yarn and npm

@insipx
Copy link
Contributor

insipx commented Nov 7, 2023

I like the docker image + but adding FMT to the current workflow is better. As far as speed for 1 vs the other I'm probably not the one to know

In general I am for reproducible environments, so like the docker container and think it will make it easier to onboard devs in the future + have an easy way to get an environment up for example if we ever have a CONTRIBUTING section as the project grows. It also serves as a good enforced dependency list even if not using docker

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@richardhuaaa
Copy link
Contributor

To use this development container in Visual Studio Code, specify the Dockerfile as the target for the Remote Containers module

Can we include this in the README for future devs? And we mean the Dev Containers extension right?

And is it correct to say that this is optional? The alternative is to configure your environment yourself?

@jac18281828 jac18281828 requested a review from jhaaaa as a code owner November 8, 2023 00:45
@jac18281828 jac18281828 force-pushed the jac/rustdev branch 3 times, most recently from 72673b3 to 8179dc4 Compare November 8, 2023 01:21
- devcontainer
- tasks.json
- github ci-image workflow
- fmt and fix fmt errors
- include Node 20.9.0 toolchain
- review feedback, remove lint flow, README.md
@jac18281828 jac18281828 merged commit d903888 into main Nov 8, 2023
4 checks passed
@jac18281828 jac18281828 deleted the jac/rustdev branch November 8, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add remote development container
4 participants