Add database models #289
Merged
Add database models #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Plaza <[email protected]>
5 tasks
insipx
reviewed
Oct 30, 2023
| user_address TEXT PRIMARY KEY NOT NULL, | ||
| created_at BIGINT NOT NULL, | ||
| last_refreshed BIGINT NOT NULL | ||
| user_address TEXT PRIMARY KEY NOT NULL, |
There was a problem hiding this comment.
are we re-using some of the tables from XMTP?
There was a problem hiding this comment.
This schema below is all we have a need for at the moment. Because OpenMLS has its own database structure with the KeyValue store, some of the tables from the old xmtp schema simply aren't necessary.
richardhuaaa
approved these changes
Oct 31, 2023
xmtp_mls/migrations/2023-10-29-205333_state_machine_init/up.sql
Outdated
Show resolved
Hide resolved
insipx
reviewed
Oct 31, 2023
richardhuaaa
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
I decided to break up the DB models into multiple files. The
xmtpcrate'sEncryptedMessageStorewas getting pretty long and unwieldy, especially for tests. I figure we can break up theimplblocks for the store methods and all the Trait implementations into the respective per-table files and things should be more manageable. Lmk what you all think.