Rename account->identity #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhuaaa
requested review from
neekolas,
dmccartney,
jhaaaa,
insipx and
a team
richardhuaaa
force-pushed
the
rich/rename-account
branch
from
edc76fc to
c71072c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating out this quick PR to make later PR's easier to review.
The word 'account' is overloaded - we previously decided that this would refer to the blockchain account or other user-level identity, rather than an individual installation under that account. Renamed to 'identity' here, which is what the openMLS CLI calls this, and is consistent with the concept of a cryptographic identity commonly referred to in docs.