Add skeleton of xmtp_mls crate #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Oct 20, 2023
xmtp_mls/Cargo.toml
Outdated
| hex = "0.4.3" | ||
| libsqlite3-sys = { version = "0.26.0", optional = true} | ||
| log = "0.4.17" | ||
| openmls = { path = "../../openmls/openmls", features = ["test-utils"] } |
There was a problem hiding this comment.
We should probably make a fork and just point at that everywhere
I have a fork now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an
xmtp_mlscrate, and copies over some of the common things we'll need from thexmtpcrate:There is no MLS-specific logic in this PR. I've made the
Accountobject an empty struct for now,Clientdoes no business logic other than holding the API client and DB, and there are no models in the database. The only changes are stripping out vmac-specific logic and wrangling to make the whole thing compile.Happy to port over #268 once it lands, if it's a hassle @dmccartney