Lower the timeout values for the rust connection #267
workspace
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.1 (d5c2e9c34 2023-09-13)
- cargo 1.72.1 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (d5c2e9c 2023-09-13)
Annotations
Check warning on line 250 in examples/cli/cli-client.rs
github-actions / workspace
the `Err`-variant returned from this function is very large
warning: the `Err`-variant returned from this function is very large
--> examples/cli/cli-client.rs:250:48
|
83 | WcConnection(#[from] ConnectorError),
| ------------------------------------ the largest variant contains at least 128 bytes
...
250 | fn get_encrypted_store(db: Option<PathBuf>) -> Result<EncryptedMessageStore, CliError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `CliError`, for example by boxing large elements or replacing it with `Box<CliError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
Check warning on line 227 in examples/cli/cli-client.rs
github-actions / workspace
writing `&String` instead of `&str` involves a new object where a slice will do
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> examples/cli/cli-client.rs:227:48
|
227 | async fn send(client: Client, addr: &str, msg: &String) -> Result<(), CliError> {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 109 in xmtp_ecies/src/signed_payload.rs
github-actions / workspace
unneeded `return` statement
warning: unneeded `return` statement
--> xmtp_ecies/src/signed_payload.rs:104:5
|
104 | / return Ok(Signature {
105 | | union: Some(Union::EcdsaCompact(EcdsaCompact {
106 | | bytes: sig.serialize().to_vec(),
107 | | recovery: recovery_u32,
108 | | })),
109 | | });
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
104 ~ Ok(Signature {
105 + union: Some(Union::EcdsaCompact(EcdsaCompact {
106 + bytes: sig.serialize().to_vec(),
107 + recovery: recovery_u32,
108 + })),
109 ~ })
|
Check warning on line 61 in xmtp_networking/src/grpc_api_helper.rs
github-actions / workspace
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> xmtp_networking/src/grpc_api_helper.rs:56:9
|
56 | / MessageApiClient<
57 | | hyper::Client<
58 | | HttpsConnector<tower::timeout::Timeout<HttpConnector>>,
59 | | UnsyncBoxBody<hyper::body::Bytes, Status>,
60 | | >,
61 | | >,
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 1329 in xmtp_proto/src/gen/xmtp.message_contents.serde.rs
github-actions / workspace
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86
|
1329 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default