Sync solo group after create in bindings #1501
Merged
+145
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cv/sync-solo-group-after-create-in-bindings
branch
from
2c3c6b8 to
e6b96c2
Compare
cameronvoell
force-pushed
the
cv/sync-solo-group-after-create-in-bindings
branch
2 times, most recently
from
408e2f9 to
5527aaf
Compare
rygine
approved these changes
Jan 14, 2025
mchenani
approved these changes
Jan 14, 2025
…-group-after-create-in-bindings
cameronvoell
merged commit 9341986
into
mc/test-update-policy-on-empty-group
15 checks passed
cameronvoell
added a commit
that referenced
this pull request
Jan 14, 2025
* test(policy): update policies of an empty group * Sync solo group after create in bindings (#1501) * sync solo group after create in bindings * fix node bindings style --------- Co-authored-by: cameronvoell <[email protected]> --------- Co-authored-by: Cameron Voell <[email protected]> Co-authored-by: cameronvoell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bindings create_group functions all create an async wrapper function around
xmtp_mlscreate_groupandcreate_group_with_members, but depending on whether you add members or not, your group will end up in a different state which is confusing. (either ready to update metadata, or requiring a sync first)This PR keeps xmtp_mls create_group function as is, but adds a
group.sync()in create_group bindings functions so that after you call create_group in bindings, you are ready to update metadata + permissions etc, regardless of whether you created the group with additional members