feat(conversations): create conversation list with last message #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age' into mc/conversation-list-w-last-message
codabrink
reviewed
Dec 19, 2024
Co-authored-by: Dakota Brink <[email protected]>
mchenani
commented
Dec 20, 2024
| @@ -1141,6 +1161,12 @@ pub struct FfiConversation { | |||
| inner: MlsGroup<RustXmtpClient>, | |||
| } | |||
|
|
|||
| #[derive(uniffi::Object)] | |||
| pub struct FfiConversationListItem { | |||
There was a problem hiding this comment.
introduced this struct to avoid changing all the current functions!
mchenani
commented
Dec 20, 2024
| @@ -965,6 +965,26 @@ impl FfiConversations { | |||
| Ok(convo_list) | |||
| } | |||
|
|
|||
| pub async fn list_conversations( | |||
There was a problem hiding this comment.
default order is:
ORDER BY COALESCE(rm.sent_at_ns, g.created_at_ns) DESC
…age' into mc/conversation-list-w-last-message
|
resolves #1181 |
nplasterer
reviewed
Dec 21, 2024
| @@ -947,6 +947,26 @@ impl FfiConversations { | |||
| Ok(convo_list) | |||
| } | |||
|
|
|||
| pub async fn list_conversations( | |||
There was a problem hiding this comment.
I'm not sure I understand when this is supposed to be used instead of the list() function above? cc @mchenani
There was a problem hiding this comment.
What I saw in android, we fetched the conversations and the get the last message one by one and map them together.
we can replace it with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a SQL view to represent the list of client conversations, including the last message in each conversation.
Context:
Previously, all conversations were loaded, and the last message for each conversation was fetched individually, resulting in inefficiencies.
Solution:
Introduced a SQL-level View to streamline fetching the conversation list, with each row including the latest message, improving performance and clarity.
close #1181