Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save group message content types #1435

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 19, 2024

Part of #1403

Adds fields to group_messages table corresponding to ContentTypeId proto and saves them when sending and receiving messages.

ContentTypeId for reference:

https://github.com/xmtp/proto/blob/404a0f41a6dc00f5de5fcfc24856c8b4e417fe59/proto/mls/message_contents/content.proto#L10-L16

// ContentTypeId is used to identify the type of content stored in a Message.
message ContentTypeId {
  string authority_id = 1;  // authority governing this content type
  string type_id = 2;       // type identifier
  uint32 version_major = 3; // major version of the type
  uint32 version_minor = 4; // minor version of the type
}

Copy link
Contributor Author

cameronvoell commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cameronvoell cameronvoell changed the title save group message content types Save group message content types Dec 19, 2024
@cameronvoell cameronvoell marked this pull request as ready for review December 19, 2024 00:23
@cameronvoell cameronvoell requested a review from a team as a code owner December 19, 2024 00:23
@cameronvoell cameronvoell force-pushed the 12-18-save_group_message_content_types branch 7 times, most recently from 0a44516 to 2bd831a Compare December 19, 2024 20:12
xmtp_mls/src/groups/mod.rs Show resolved Hide resolved
xmtp_mls/src/storage/encrypted_store/group_message.rs Outdated Show resolved Hide resolved
xmtp_mls/src/storage/encrypted_store/group_message.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated review

xmtp_mls/src/groups/mod.rs Outdated Show resolved Hide resolved
xmtp_mls/src/groups/mod.rs Outdated Show resolved Hide resolved
@cameronvoell cameronvoell force-pushed the 12-18-save_group_message_content_types branch from dc6428c to fbed7ce Compare December 19, 2024 23:30
@cameronvoell cameronvoell requested a review from insipx December 19, 2024 23:34
@cameronvoell cameronvoell force-pushed the 12-18-save_group_message_content_types branch 2 times, most recently from ac4dbaf to ca5c57a Compare December 19, 2024 23:51
@cameronvoell cameronvoell force-pushed the 12-18-save_group_message_content_types branch from ca5c57a to 247a7e1 Compare December 20, 2024 01:05
@cameronvoell cameronvoell merged commit db84199 into main Dec 20, 2024
13 checks passed
@cameronvoell cameronvoell deleted the 12-18-save_group_message_content_types branch December 20, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants