Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor XDGB edge cases #1425

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Minor XDGB edge cases #1425

merged 3 commits into from
Dec 16, 2024

Conversation

mkysel
Copy link
Contributor

@mkysel mkysel commented Dec 16, 2024

This fixes 3 minor issues:

  1. when the user does not specify a subcommand XDBG exits with code 0. This can be a bit confusing. Print help instead and exit with an error.
  • I am open to other options. Printing to stderr and std::process:exit(1) are also pretty good choices.
  1. Generate could not print help
$ cargo run --package xdbg -- generate -h
    Finished `dev` profile [unoptimized] target(s) in 0.19s
     Running `target/debug/xdbg generate -h`
The application panicked (crashed).
Message:  Command generate: Short option names must be unique for each argument, but '-i' is in use by both 'invite' and 'interval'
Location: /Users/martinkysel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.23/src/builder/debug_asserts.rs:112

Now it can

  1. Typo in loclalhosltls

@mkysel mkysel requested a review from a team as a code owner December 16, 2024 19:06
@mkysel mkysel requested a review from insipx December 16, 2024 19:06
@mkysel mkysel enabled auto-merge (squash) December 16, 2024 19:18
@mkysel mkysel merged commit 567751f into main Dec 16, 2024
7 checks passed
@mkysel mkysel deleted the mkysel/xdbg-options branch December 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants