Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate grpc channel connection from create_client #1415

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Separate grpc channel connection from create_client #1415

merged 1 commit into from
Dec 16, 2024
+128 −77

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Dec 13, 2024 •
edited
Loading

Screenshot 2024-12-13 at 5 21 17 PM

Screenshot 2024-12-13 at 5 21 42 PM

Screenshot 2024-12-13 at 5 22 01 PM

@insipx insipx mentioned this pull request Dec 13, 2024
Merged
@insipx Graphite App
Copy link
Contributor Author

insipx commented Dec 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@insipx insipx force-pushed the 12-13-make_client_creation_fast branch from 0458d8f to 00b8e24 Compare December 13, 2024 22:23
@insipx insipx force-pushed the 12-06-benchmarks_for_create_client branch from 5f0810a to 49ef097 Compare December 13, 2024 22:25
@insipx insipx force-pushed the 12-13-make_client_creation_fast branch 2 times, most recently from 430adfa to 269f908 Compare December 13, 2024 22:26
@insipx insipx changed the title make client creation fast Separate grpc channel connection from create_client Dec 13, 2024
@insipx insipx marked this pull request as ready for review December 13, 2024 22:31
@insipx insipx requested a review from a team as a code owner December 13, 2024 22:31
@insipx insipx force-pushed the 12-13-make_client_creation_fast branch from 269f908 to 1b92c6b Compare December 13, 2024 22:31
@insipx insipx changed the base branch from 12-06-benchmarks_for_create_client to graphite-base/1415 December 16, 2024 15:41
@insipx insipx force-pushed the 12-13-make_client_creation_fast branch from 1b92c6b to 9cf18da Compare December 16, 2024 15:41
@insipx insipx force-pushed the graphite-base/1415 branch from 49ef097 to 97eca90 Compare December 16, 2024 15:41
@insipx insipx merged commit eb2cc15 into graphite-base/1415 Dec 16, 2024
23 checks passed
@insipx insipx deleted the 12-13-make_client_creation_fast branch December 16, 2024 15:41
@insipx insipx restored the 12-13-make_client_creation_fast branch December 17, 2024 16:28
@insipx insipx mentioned this pull request Dec 17, 2024
Merged
@insipx insipx deleted the 12-13-make_client_creation_fast branch December 17, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @nplasterer