Create a lock struct for the mls groups #1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codabrink
force-pushed
the
cb/thread-safety
branch
from
0529705 to
e748ab5
Compare
codabrink
force-pushed
the
cb/thread-safety
branch
from
e748ab5 to
61ce53e
Compare
insipx
reviewed
Dec 16, 2024
xmtp_mls/src/groups/serial.rs
Outdated
| .clone(); | ||
|
|
||
| // this may block | ||
| let lock = mutex.blocking_lock(); |
There was a problem hiding this comment.
Do we ever use this variant?
I'm surprised the webassembly tests pass, under the hood this uses futures::block_on which will panic the WASM executor. I suspect we maybe don't have any webassembly tests that use code touching the lock
There was a problem hiding this comment.
We do not, it's just there in case it's used in the future.
insipx
reviewed
Dec 16, 2024
|
Going to close my PR in favor of @cameronvoell's PR which seems to fix the root issue #1416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.