Move content types to new crate #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cameronvoell
changed the title
cameronvoell
changed the title
12 tasks
cameronvoell
force-pushed
the
12-10-feat_adding_new_xmtp_content_types_crate
branch
from
1c4da9c to
c87f599
Compare
cameronvoell
force-pushed
the
12-10-feat_adding_new_xmtp_content_types_crate
branch
from
c87f599 to
7645d95
Compare
cameronvoell
force-pushed
the
12-10-feat_adding_new_xmtp_content_types_crate
branch
from
0231754 to
bae42ca
Compare
neekolas
approved these changes
Dec 11, 2024
cameronvoell
deleted the
12-10-feat_adding_new_xmtp_content_types_crate
branch
insipx
reviewed
Dec 11, 2024
| xmtp_proto = { workspace = true, features = ["convert"] } | ||
|
|
||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] | ||
| tonic = { version = "0.12", features = ["transport"] } |
There was a problem hiding this comment.
where do we/will we use tonic in this crate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1403
See XIP-48 Queryable Content Types in Rust: xmtp/XIPs#74