Skip to content

Commit

Permalink
fix: cleanup wip notes
Browse files Browse the repository at this point in the history
  • Loading branch information
tuddman committed Aug 2, 2024
1 parent 8efba60 commit 4d4ec95
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions xmtp_mls/src/groups/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ impl MlsGroup {
),
};

validate_initial_group_membership(&client, provider.conn_ref(), &mls_group).await?;
validate_initial_group_membership(client, provider.conn_ref(), &mls_group).await?;

let stored_group = provider.conn().insert_or_replace_group(to_store)?;

Expand All @@ -348,14 +348,6 @@ impl MlsGroup {
stored_group.created_at_ns,
);

// ??: set up the stream here for history sync responder?
if group_type == ConversationType::Sync {
let mut stream = client.stream_messages(HashMap::new()).await?;
// let (tx, rx) = oneshot::channel();
let handle = tokio::spawn(async move {});
// StreamHandle
}

Ok(group)
}

Expand Down Expand Up @@ -386,7 +378,7 @@ impl MlsGroup {
let added_by_credential = BasicCredential::try_from(added_by_node.credential().clone())?;
let inbox_id = parse_credential(added_by_credential.identity())?;

Self::create_from_welcome(client.clone(), provider, welcome, inbox_id, welcome_id).await
Self::create_from_welcome(client, provider, welcome, inbox_id, welcome_id).await
}

pub(crate) fn create_and_insert_sync_group(
Expand Down

0 comments on commit 4d4ec95

Please sign in to comment.