RecoverableEcdsaSignature #956
Annotations
15 warnings
unneeded `return` statement:
xmtp_id/src/associations/serialization.rs#L178
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:178:17
|
178 | None => return Err(DeserializationError::MissingSignature),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
178 | None => Err(DeserializationError::MissingSignature),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
unneeded `return` statement:
xmtp_id/src/associations/serialization.rs#L158
warning: unneeded `return` statement
--> xmtp_id/src/associations/serialization.rs:158:17
|
158 | None => return Err(DeserializationError::MissingMemberIdentifier),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
158 | None => Err(DeserializationError::MissingMemberIdentifier),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
xmtp_id/src/associations/serialization.rs#L110
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> xmtp_id/src/associations/serialization.rs:110:14
|
110 | actions: &Vec<IdentityActionKindProto>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[IdentityActionKindProto]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
all variants have the same prefix: `Missing`:
xmtp_id/src/associations/serialization.rs#L28
warning: all variants have the same prefix: `Missing`
--> xmtp_id/src/associations/serialization.rs:28:1
|
28 | / pub enum DeserializationError {
29 | | #[error("Missing action")]
30 | | MissingAction,
31 | | #[error("Missing member identifier")]
... |
34 | | MissingSignature,
35 | | }
| |_^
|
= help: remove the prefixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
redundant closure:
xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:89:13
|
89 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
unnecessary map of the identity function:
xmtp_mls/src/groups/members.rs#L42
warning: unnecessary map of the identity function
--> xmtp_mls/src/groups/members.rs:42:22
|
42 | .ok()
| ______________________^
43 | | .map(|basic_credential| (basic_credential))?;
| |___________________________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
|
returning the result of a `let` binding from a block:
xmtp_api_grpc/src/auth_token.rs#L59
warning: returning the result of a `let` binding from a block
--> xmtp_api_grpc/src/auth_token.rs:59:9
|
58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
| ---------------------------------------------------------------------------------- unnecessary `let` binding
59 | token_base64
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
58 ~
59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes)
|
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L2424
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
|
2424 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2951
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
|
2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.identity.associations.serde.rs#L916
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.identity.associations.serde.rs:916:105
|
916 | struct_ser.serialize_field("installationPublicKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
this function has too many arguments (8/7):
src/mls.rs#L49
warning: this function has too many arguments (8/7)
--> src/mls.rs:49:1
|
49 | / pub async fn create_client(
50 | | logger: Box<dyn FfiLogger>,
51 | | host: String,
52 | | is_secure: bool,
... |
57 | | legacy_signed_private_key_proto: Option<Vec<u8>>,
58 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> {
| |_____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|