Skip to content

Mutable Metadata via new UpdateMetadata intent kind #1717

Mutable Metadata via new UpdateMetadata intent kind

Mutable Metadata via new UpdateMetadata intent kind #1717

Triggered via pull request April 9, 2024 17:57
Status Success
Total duration 6m 24s
Artifacts

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
redundant closure: xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure --> xmtp_mls/src/groups/subscriptions.rs:89:13 | 89 | move |message| callback(message), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L2537
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2537:91 | 2537 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115 | 391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99 | 387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2951
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86 | 2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86 | 1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
this function has too many arguments (8/7): src/mls.rs#L49
warning: this function has too many arguments (8/7) --> src/mls.rs:49:1 | 49 | / pub async fn create_client( 50 | | logger: Box<dyn FfiLogger>, 51 | | host: String, 52 | | is_secure: bool, ... | 57 | | legacy_signed_private_key_proto: Option<Vec<u8>>, 58 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> { | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test: xmtp_mls/src/groups/group_mutable_metadata.rs#L96
unused import: `super::*`
Test
`xmtp_mls` (lib test) generated 1 warning (run `cargo fix --lib -p xmtp_mls --tests` to apply 1 suggestion)