Who Added Me #874
Annotations
1 error and 11 warnings
build
buildx failed with: ERROR: failed to solve: process "/bin/sh -c cargo fmt --check" did not complete successfully: exit code: 1
|
redundant closure:
xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:89:13
|
89 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
unnecessary map of the identity function:
xmtp_mls/src/groups/members.rs#L42
warning: unnecessary map of the identity function
--> xmtp_mls/src/groups/members.rs:42:22
|
42 | .ok()
| ______________________^
43 | | .map(|basic_credential| (basic_credential))?;
| |___________________________________________________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
|
returning the result of a `let` binding from a block:
xmtp_api_grpc/src/auth_token.rs#L59
warning: returning the result of a `let` binding from a block
--> xmtp_api_grpc/src/auth_token.rs:59:9
|
58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
| ---------------------------------------------------------------------------------- unnecessary `let` binding
59 | token_base64
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
58 ~
59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes)
|
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L2424
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91
|
2424 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2951
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86
|
2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
this function has too many arguments (8/7):
src/mls.rs#L48
warning: this function has too many arguments (8/7)
--> src/mls.rs:48:1
|
48 | / pub async fn create_client(
49 | | logger: Box<dyn FfiLogger>,
50 | | host: String,
51 | | is_secure: bool,
... |
56 | | legacy_signed_private_key_proto: Option<Vec<u8>>,
57 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> {
| |_____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
build
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.314.1. Please update to the latest version 2.315.0
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|