Process streamed group message #682
Annotations
6 errors and 10 warnings
cannot find function `process_streamed_welcome_message` in this scope:
src/mls.rs#L224
error[E0425]: cannot find function `process_streamed_welcome_message` in this scope
--> src/mls.rs:224:23
|
224 | let message = process_streamed_welcome_message(envelope).into();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
|
help: consider using the method on `Self`
|
224 | let message = self.process_streamed_welcome_message(envelope).into();
| +++++
|
the trait bound `mls::FfiGroup: uniffi::LowerReturn<UniFfiTag>` is not satisfied:
src/mls.rs#L223
error[E0277]: the trait bound `mls::FfiGroup: uniffi::LowerReturn<UniFfiTag>` is not satisfied
--> src/mls.rs:223:80
|
223 | pub fn process_streamed_welcome_message(&self, envelope_bytes: Vec<u8>) -> Result<FfiGroup, GenericError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `uniffi::LowerReturn<UniFfiTag>` is not implemented for `mls::FfiGroup`, which is required by `std::result::Result<mls::FfiGroup, GenericError>: uniffi::LowerReturn<UniFfiTag>`
|
= help: the following other types implement trait `uniffi::LowerReturn<UT>`:
bool
i8
i16
i32
i64
u8
u16
u32
and 29 others
= note: required for `std::result::Result<mls::FfiGroup, GenericError>` to implement `uniffi::LowerReturn<UniFfiTag>`
|
the trait bound `mls::FfiGroup: uniffi::LowerReturn<UniFfiTag>` is not satisfied:
src/mls.rs#L187
error[E0277]: the trait bound `mls::FfiGroup: uniffi::LowerReturn<UniFfiTag>` is not satisfied
--> src/mls.rs:187:1
|
187 | #[uniffi::export(async_runtime = "tokio")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `uniffi::LowerReturn<UniFfiTag>` is not implemented for `mls::FfiGroup`, which is required by `std::result::Result<mls::FfiGroup, GenericError>: uniffi::LowerReturn<UniFfiTag>`
|
= help: the following other types implement trait `uniffi::LowerReturn<UT>`:
bool
i8
i16
i32
i64
u8
u16
u32
and 29 others
= note: required for `std::result::Result<mls::FfiGroup, GenericError>` to implement `uniffi::LowerReturn<UniFfiTag>`
= note: this error originates in the attribute macro `uniffi::export` (in Nightly builds, run with -Z macro-backtrace for more info)
|
cannot find value `envelope` in this scope:
src/mls.rs#L371
error[E0425]: cannot find value `envelope` in this scope
--> src/mls.rs:371:60
|
371 | let message = group.process_streamed_group_message(envelope).into();
| ^^^^^^^^ not found in this scope
|
cannot find value `envelope` in this scope:
src/mls.rs#L224
error[E0425]: cannot find value `envelope` in this scope
--> src/mls.rs:224:56
|
224 | let message = process_streamed_welcome_message(envelope).into();
| ^^^^^^^^ not found in this scope
|
lint
Clippy had exited with the 101 exit code
|
unnecessary map of the identity function:
xmtp_mls/src/subscriptions.rs#L80
warning: unnecessary map of the identity function
--> xmtp_mls/src/subscriptions.rs:80:62
|
80 | let welcome = self.process_streamed_welcome(envelope).map_err(|e| e)?;
| ^^^^^^^^^^^^^^^ help: remove the call to `map_err`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
|
redundant closure:
xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure
--> xmtp_mls/src/groups/subscriptions.rs:89:13
|
89 | move |message| callback(message),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
unnecessary map of the identity function:
xmtp_mls/src/groups/subscriptions.rs#L55
warning: unnecessary map of the identity function
--> xmtp_mls/src/groups/subscriptions.rs:55:64
|
55 | let message = self.process_stream_entry(envelope).await.map_err(|e| e)?;
| ^^^^^^^^^^^^^^^ help: remove the call to `map_err`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
|
returning the result of a `let` binding from a block:
xmtp_api_grpc/src/auth_token.rs#L59
warning: returning the result of a `let` binding from a block
--> xmtp_api_grpc/src/auth_token.rs:59:9
|
58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes);
| ---------------------------------------------------------------------------------- unnecessary `let` binding
59 | token_base64
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
58 ~
59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes)
|
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115
|
391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99
|
387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2934
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2934:86
|
2934 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
the borrowed expression implements the required traits:
xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits
--> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86
|
1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?;
| ^^ help: change this to: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|