Skip to content

build: add a PPPP identifier reference test #720

build: add a PPPP identifier reference test

build: add a PPPP identifier reference test #720

Triggered via pull request November 3, 2023 21:17
Status Success
Total duration 24m 35s
Artifacts

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
the `Err`-variant returned from this function is very large: examples/cli/cli-client.rs#L250
warning: the `Err`-variant returned from this function is very large --> examples/cli/cli-client.rs:250:48 | 83 | WcConnection(#[from] ConnectorError), | ------------------------------------ the largest variant contains at least 128 bytes ... 250 | fn get_encrypted_store(db: Option<PathBuf>) -> Result<EncryptedMessageStore, CliError> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: try reducing the size of `CliError`, for example by boxing large elements or replacing it with `Box<CliError>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
writing `&String` instead of `&str` involves a new object where a slice will do: examples/cli/cli-client.rs#L227
warning: writing `&String` instead of `&str` involves a new object where a slice will do --> examples/cli/cli-client.rs:227:48 | 227 | async fn send(client: Client, addr: &str, msg: &String) -> Result<(), CliError> { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
very complex type used. Consider factoring parts into `type` definitions: xmtp_networking/src/grpc_api_helper.rs#L56
warning: very complex type used. Consider factoring parts into `type` definitions --> xmtp_networking/src/grpc_api_helper.rs:56:9 | 56 | / MessageApiClient< 57 | | hyper::Client< 58 | | HttpsConnector<tower::timeout::Timeout<HttpConnector>>, 59 | | UnsyncBoxBody<hyper::body::Bytes, Status>, 60 | | >, 61 | | >, | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
unneeded `return` statement: xmtp_ecies/src/signed_payload.rs#L104
warning: unneeded `return` statement --> xmtp_ecies/src/signed_payload.rs:104:5 | 104 | / return Ok(Signature { 105 | | union: Some(Union::EcdsaCompact(EcdsaCompact { 106 | | bytes: sig.serialize().to_vec(), 107 | | recovery: recovery_u32, 108 | | })), 109 | | }); | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 104 ~ Ok(Signature { 105 + union: Some(Union::EcdsaCompact(EcdsaCompact { 106 + bytes: sig.serialize().to_vec(), 107 + recovery: recovery_u32, 108 + })), 109 ~ }) |
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1329
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86 | 1329 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
unneeded `return` statement: src/lib.rs#L142
warning: unneeded `return` statement --> src/lib.rs:142:9 | 142 | / return Ok(QueryResponse { 143 | | envelopes: new_messages, 144 | | ..QueryResponse::default() 145 | | } 146 | | .encode_to_vec()); | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 142 ~ Ok(QueryResponse { 143 + envelopes: new_messages, 144 + ..QueryResponse::default() 145 + } 146 ~ .encode_to_vec()) |
use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead: /home/runner/work/libxmtp/libxmtp/xmtp_networking/src/grpc_api_helper.rs#L22
warning: use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead --> /home/runner/work/libxmtp/libxmtp/xmtp_networking/src/grpc_api_helper.rs:22:11 | 22 | roots.add_server_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.0.iter().map(|ta| { | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test: xmtp_networking/src/grpc_api_helper.rs#L22
use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead
Test
`xmtp_networking` (lib) generated 1 warning
Test: xmtp_networking/src/grpc_api_helper.rs#L22
use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead
Test
`xmtp_networking` (lib) generated 1 warning