Skip to content

Key package methods #105

Key package methods

Key package methods #105

Triggered via pull request October 30, 2023 22:53
Status Success
Total duration 15m 2s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

4 warnings
use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead: xmtp_api_grpc/src/grpc_api_helper.rs#L27
warning: use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead --> xmtp_api_grpc/src/grpc_api_helper.rs:27:11 | 27 | roots.add_server_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.0.iter().map(|ta| { | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
useless conversion to the same type: `std::collections::hash_map::Values<'_, std::vec::Vec<u8>, std::vec::Vec<u8>>`: xmtp_mls/src/client.rs#L164
warning: useless conversion to the same type: `std::collections::hash_map::Values<'_, std::vec::Vec<u8>, std::vec::Vec<u8>>` --> xmtp_mls/src/client.rs:164:12 | 164 | Ok(key_package_results | ____________^ 165 | | .values() 166 | | .into_iter() | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `.into_iter()` | 164 ~ Ok(key_package_results 165 + .values() |
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1329
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1329:86 | 1329 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/