Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30: remove dependency on anvil in pages build #31

Closed
wants to merge 1 commit into from

Conversation

jac18281828
Copy link
Contributor

@jac18281828 jac18281828 commented Jan 13, 2024

closes #30

  • move abi to root
  • pages does not depend on foundry

@jac18281828 jac18281828 self-assigned this Jan 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7a8510) 91.30% compared to head (de11464) 91.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          11       11           
  Lines        1288     1288           
=======================================
  Hits         1176     1176           
  Misses        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


//TODO: Add tests for: Errors, formats, entire document asserts, different padding methods(0s and spaces)

#[tokio::test]
pub async fn test_attributes() -> Result<()> {
with_client(None, |client, registry, signer, _| async move {
let me = signer.address();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting got a little wonky here, might need to run cargo fmt

@jac18281828 jac18281828 deleted the jac/pages30 branch January 21, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pages depending on anvil and integration tests
3 participants