-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix jenkins label and update xjsl to 0.28 #320
Conversation
Apparently there is an XN file which requires the test to be run on a vrd-type board
running once more with full test enabled as thats where we saw the issues (once merged to develop) |
ok next issue is the new jenkins agents have 2 boards attached. dfu-utils needs one selected but we need to translate xtagid into something dfu-utils can understand.
|
@BrennanGit, I updated this PR with the latest changes from develop. Can you check I solved the merge conflicts correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
numpy version doesn't support 3.10
@BrennanGit any reason we shouldn't merge this? |
I wasn't sure the multiple xtags for dfu-utils had been resolved but it does seem to be passing. The PYTHON_VERSION fix is pretty crucial though. Happy to merge if this next build passes. |
BTW, this fail - https://github.com/xmos/sln_voice/actions/runs/6719127858 is fixed in #325 which should be merged shortly |
I did a full run and it passed dfu so it's all good. By the time it finished, the base branch had been updated. Last time for sure now. |
Despite #301 being merged, it seems there were tests that only run on nightlies that saw issues we attempt to remedy here.
Apparently there is an XN file which requires the test to be run on a vrd-type board.
Also needed to fix the /projects mount path as we moved off the US agents.
examples:
Also including the xjsl version bump we've seen elsewhere. The most significant change in which is the build discarder.