Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jenkins label and update xjsl to 0.28 #320

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

BrennanGit
Copy link
Contributor

@BrennanGit BrennanGit commented Oct 16, 2023

Despite #301 being merged, it seems there were tests that only run on nightlies that saw issues we attempt to remedy here.

Apparently there is an XN file which requires the test to be run on a vrd-type board.
Also needed to fix the /projects mount path as we moved off the US agents.

examples:

Also including the xjsl version bump we've seen elsewhere. The most significant change in which is the build discarder.

Apparently there is an XN file which requires the test to be run on a vrd-type board
@BrennanGit
Copy link
Contributor Author

running once more with full test enabled as thats where we saw the issues (once merged to develop)

@BrennanGit
Copy link
Contributor Author

ok next issue is the new jenkins agents have 2 boards attached.

dfu-utils needs one selected but we need to translate xtagid into something dfu-utils can understand.

dfu-util: Invalid DFU suffix signature
dfu-util: A valid DFU suffix will be required in a future dfu-util release!!!
dfu-util: More than one DFU capable USB device found! Try `--list' and specify the serial number or disconnect all but one device

@xluciano
Copy link
Contributor

@BrennanGit, I updated this PR with the latest changes from develop. Can you check I solved the merge conflicts correctly?

Copy link
Contributor

@xluciano xluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@ed-xmos
Copy link
Contributor

ed-xmos commented Nov 1, 2023

@BrennanGit any reason we shouldn't merge this?

@BrennanGit
Copy link
Contributor Author

BrennanGit commented Nov 1, 2023

I wasn't sure the multiple xtags for dfu-utils had been resolved but it does seem to be passing. The PYTHON_VERSION fix is pretty crucial though.

Happy to merge if this next build passes.

@ed-xmos
Copy link
Contributor

ed-xmos commented Nov 1, 2023

BTW, this fail - https://github.com/xmos/sln_voice/actions/runs/6719127858 is fixed in #325 which should be merged shortly

@BrennanGit
Copy link
Contributor Author

I did a full run and it passed dfu so it's all good. By the time it finished, the base branch had been updated. Last time for sure now.

@BrennanGit BrennanGit merged commit bb3be00 into xmos:develop Nov 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants