Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sync tests #274

Merged
merged 18 commits into from
Aug 8, 2022
Merged

Feature/sync tests #274

merged 18 commits into from
Aug 8, 2022

Conversation

xross
Copy link
Collaborator

@xross xross commented Jul 5, 2022 •
edited
Loading

  • Sync mode now handles disappearance of host-SOF clock
  • Removed some use of globals to aid unit testing
  • Removed use of floats from sync mode code
  • Added test for basic reference clock generation in sync mode
  • Doesn't handle graceful transition of internal to SOF clock (documented in In sync mode there is no nice transition from internal to SOF clock #275)
    • Test authored for this case - marked as known failure
  • Moved i2s loopback test from xmostest to pytest & test_support
  • Auto-format of python old test code (black)

TODO:

  • Run tests from Jenkins (ideally one call to pytest for all tests)

@xross xross marked this pull request as draft July 5, 2022 17:15
xross added 11 commits July 13, 2022 16:49
@xross
Conflicted merge
06822c7
@xross
Update to latest test_support api
36dedc4
@xross
Auto-format via black
a0f5591
@xross
Remove some use of global resources
9fdacb2
@xross
* Sync mode: added basic move to internal clock when SOF clock not av…
4f36ce4 
…ailable (not change over on plug event is not smooth)

* Sync mode: Removed use of float
@xross
Slight tidy to clockgen
2b679d1
@xross
Add tracing related options to conftest
43c561c
@xross
Sync related timing defines can now be overridden
2b19097
@xross
Added basic test for PLL reference generation on Sync mode
2c01f44
@xross
* Renamed test_sync to test_sync_clk_basic
3a9f2ff 
* Authored test for known issue in sync mode, test_sync_clk_plugin
* Removed some unrequired test related files
@xross
- test_sync_clk_basic and test_sync_clk_plugin now run at FS & HS
5690442 
- test_sync_clk_plugin marked as known failure (now fails as expected for HS and FS)
@xross xross marked this pull request as ready for review August 4, 2022 19:01
@xross xross requested a review from danielpieczko August 4, 2022 19:04
@xross xross merged commit ce41732 into xmos:develop Aug 8, 2022
@xross xross deleted the feature/sync_tests branch August 8, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpieczko danielpieczko danielpieczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xross @danielpieczko