-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address review comments #214
Conversation
Sorry I was in a meeting for a while. For reference, my exclude patterns now looks like this:
The only other thing that leaps out is this error: I think this is because the section it refers to is included twice, once by each document. Might I suggest we just remove the licensing section from the top-level index.rst? I'd think it's visible enough as it is. |
I removed that reference and rephrased the text. See 4e07363. |
The last issue is this: Buit this appears to be fixed on develop already |
Part of https://xmosjira.atlassian.net/browse/AP-236