-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release v3.0.5 #207
Pre-release v3.0.5 #207
Conversation
#192) * remove redundant pytest from check_wifi, try new check_usb.sh based off old run_tests, update readme
v3.0.4 release merge back to develop
…_usb_rate Log SOF timestamps
i2c_master_remote_write() nullptr fix
fixes for xmosdoc v4
Add dummy definitions to avoid warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only very minor comments and some questions.
@@ -1,6 +1,5 @@ | |||
.. _fwk_rtos_copyright: | |||
|
|||
.. include:: ../_templates/disclaimer.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has the disclaimer been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrennanGit, can you answer the question above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These days we don't autogenerate a disclaimer, in general moving away from autogenerated pages.
The alternative is to use a set of substitutions like we see in fwk_core: https://raw.githubusercontent.com/xmos/fwk_core/develop/doc/shared/legal.rst
Not sure why it wasn't added here, happy to do so if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with fwk_core, we should include in fwk_rtos (and fwk_io if it's not already there):
Copyright & Disclaimer
======================
|XMOS copyright|
|XMOS disclaimer|
|XMOS trademarks|
This text appears above the Licence section.
Include xs1.h in rtos_swmem.c and update documentation
doc/exclude_patterns.inc
Outdated
tools | ||
projects | ||
test | ||
xmos_cmake_toolchain | ||
modules/drivers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this has been excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon it was to avoid building the documents inside that repo. Do you think we should include that folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an important part of the package. So yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes only which I have suggested. Approving and will trust you to address them.
Update copyright notices
Address review comments
avoid warnings when configNUM_CORES is set to 1.
This PR includes the documentation updates needed to use xmosdoc v4.
Part of https://xmosjira.atlassian.net/browse/AP-236