Add code and tests for checking DOM Node types #4
Conversation
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export function isNodeLike(value: any): value is Node { |
There was a problem hiding this comment.
The definition of Node is coming from the DOM lib of typescript, right?
There was a problem hiding this comment.
Correct. This would be the same definition that would be in use if they used TypeScript in a browser.
| @@ -0,0 +1,7 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
One more question, is the release workflow requiring you to already put the updated changelog into the branch?
And did you manage to already publish it somewhere, which triggered the creation of this file?
There was a problem hiding this comment.
I tried running my tooling to generate the file, but it generated an empty file because there is no tag to look at. After the first release, it will automatically build a changelog from all the PRs. Look at this as a placeholder. If you don't want it there now (because it is empty), that's fine; I'll remove it.
|
Not sure why this PR is not using your workflow files, but I guess it is because you created the PR from a fork. Would be curious to see them running before merging. |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cjbarth
changed the title
No description provided.