replace select with poll in nopoll #36
Conversation
|
|
| @@ -66,7 +66,7 @@ noPollPtr nopoll_io_wait_select_create (noPollCtx * ctx) | |||
| * | |||
| * @param fd_group The fd group to be deallocated. | |||
| */ | |||
| void nopoll_io_wait_select_destroy (noPollCtx * ctx, noPollPtr fd_group) | |||
| void nopoll_io_wait_select_destroy (noPollCtx * ctx, noPollPtr __fd_group) | |||
There was a problem hiding this comment.
variables with double underscores are generally reserved by libc as private namespace.
There was a problem hiding this comment.
Numerous nopoll modules violate this rule, with numerous function names, parameter names, and variable names that start with double underscores.
So the question for us would be how to deal with software we didn't write that has already been written to a standard we don't agree with.
In this specific case, I thought it was best to just conform to the naming convention already being used in this module, nopoll_io.c.
src/nopoll_decl.h
Outdated
| @@ -216,7 +216,8 @@ | |||
| #include <sys/socket.h> | |||
| #include <netinet/in.h> | |||
| #include <arpa/inet.h> | |||
| #include <sys/select.h> | |||
| /* #include <sys/select.h> */ | |||
| #define NOPOLL_HAVE_POLL 1 | |||
There was a problem hiding this comment.
this should be automatically detected with autoconf if not then we should add the test to configure script.
There was a problem hiding this comment.
I will try without the #define.
Replace select with poll in nopoll.