Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ability to specify a titleView on sections. #522

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds ability to specify a titleView on sections. #522

wants to merge 5 commits into from

Conversation

markrickert
Copy link

Example usage:

section = [XLFormSectionDescriptor formSectionWithTitle:@"Real examples"];
section.titleView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 320, 50)]
// Basically anything that's a subclass of UIView

The UITableViewDelegate will fall back to using -(NSString *)tableView:(UITableView *)tableView titleForHeaderInSection:(NSInteger) if the titleView is nil.

@bmichotte
Copy link
Contributor

👍 It will be an awesome feature in ProMotion-XLForm

@markrickert
Copy link
Author

Any chance of getting this merged?

@markrickert
Merge branch 'master' into section_title_view
ff9a3e6 
* master: (23 commits)
  Add XLFormRowDescriptorTypeImage
  improve RTL language support.
  prevent XLFormInlineSelectorCell from removing the row beneath when not first responder
  fix xmartlabs#629
  upgrade travis Xcode version to 7
  fix xmartlabs#554 and xmartlabs#628.
  Tidied up master header, adding imports for missing public headers.
  Add Carthage documentation to README.
  Add Carthage support.
  XLFormButtonCell -> textLabel -> textAlignment changed to NSTextAlignmentNatural. Looks much better for RTL languages
  clean up swift example code
  clean up swift code.
  clean up swift example project
  Xcode 7 changes
  minor change
  Announcing Eureka - Elegant iOS Forms in pure Swift 2
  Update to Swift 2.0
  fixed layout constraints when working with iPad or big iPhones. closes xmartlabs#554.
  add NSCoding protocol a XLFormOptionsObject class
  Change XLFormDateCell to call update when value changes, so that subclasses can change the UI properly
  ...
@markrickert
Copy link
Author

Pretty please? 👍

I hate having to reference my branch instead of the official cocoapod. 😢

@markrickert
Merge branch 'master' into section_title_view
ff10842 
* master: (28 commits)
  added validators copy to rowDescriptor copyWithZone. Fixes xmartlabs#729
  release version 3.1.1
  fixed crash when launching action sheet from iOS 9
  Setting row descriptor will not fire cell config. This is done when updating the row.
  Correct the spelling of CocoaPods in README
  Removed Duplicated folder `Examples` under `Examples/Swift` closes xmartlabs#698
  fix bug: fixed UIViewController's instance, which does not inherit from XLFormViewController, using subclass of XLFormBaseCell will crash when its getFirstResponder method is invoked.
  Fixed normal and inline picker views to use row's value transformer for display text
  Changed the minimum deployment target to 8.0 to support iOS 8 for developers installing the library through a git submodule
  fix no containsString: method in NSString under iOS8_0
  end editing on scroll is an option
  Fix build error ‘XLFormImageCell.h’ file not found by moving XLFormImageCell from project header to public header
  Added custom inline row example in Objective C and Swift.
  allow setting the width percentage of an UITextView. Closes xmartlabs#534
  update readme delegate section
  Try to remove the most exception when defining the hidden and disabled predicates. Will still throw an exception when defining forward dependencies
  order example groups alphabetically. Replace formSegueIdenfifiers in SwiftExample
  Fix build error "‘XLFormImageCell.h’ file not found" by including XLFormImageCell into project file.
  update version to 3.1.0
  Button row style must not be default any more. Can display value on right of button cell. Closes xmartlabs#595, fixes #
  ...
@mats-claassen
Copy link
Member

It seems to me that this does not work well together with sections that have a title set. It changes the way the headerheight is calculated

@markrickert
Merge branch 'master' into section_title_view
47fac98 
* master:
  update pod spec for new release
  fixed tests pod spec
  Update row in `cellForRowAtIndexPath` instead of `willDisplayCell`. Add Changelog
  fix button cell disabled state. closes xmartlabs#780
  fixed designated initialiser setting back to nib name and coder
  Removed the setting of default keyboard type in text and name row.
  iOS 7 fix
  small fix in XLFormLeftRightSelectorOptionLeftValueChangePolicy enum
  XLFormLeftRightSelectorOptionLeftValueChangePolicy added
  Current a XLFormViewController-subclass in Swift cannot have a custom init (it will crash at runtime with an 'unimplemented initializer' error). This fix adds designated initializer markings on the view controller and refactors them to all call the designated initializer.
  Add cancel action to image selector
  Fix typo in README for Objective-C code
  updated podfile for compatibility with cocoapods 1.0, did pod deintegrate on project to remove cruft - fixes warnings on 'pod install': 'The dependency ... is not used in any concrete target'
  XLFormDateCell applies cellConfiguration on value change
@markrickert
Merge branch 'master' into section_title_view
7338788 
* master: (27 commits)
  Add property in XLFormTextViewCell to limit number of characters
  Add property in XLFormTextFieldCell to limit number of characters
  change XLFormUnspecifiedHeight constant to not collide with Automatic dimension
  datePicker.locale property public to developer,for example, _birthdayRow = [XLFormRowDescriptor formRowDescriptorWithTag:kBirthdayTag rowType:XLFormRowDescriptorTypeDateInline title:@"Birthday"]; [_birthdayRow.cellConfig setObject:[[NSLocale alloc] initWithLocaleIdentifier:@"en"] forKey:@"locale"];
  Refactored '-(id)init' to '- (instancetype)init'
  Update 'initializeForm' example.
  Update pod badge
  [fixes xmartlabs#452] respect the currentLocale when parsing decimal values
  Remove the fix for suppressing "Empty snapshot" warnings when presenting action sheets
  Updated code to actually use the optionTitle variable
  Fixed selector action sheet to use the row's value transformer
  update pod version
  added count to empty check. Helpful to validate multiple selectors being empty
  Fix decimal number formatting. closes xmartlabs#514
  Added height property to XLFormRowDescriptor
  updated readme with some comments. Fixes xmartlabs#771, fixes xmartlabs#727, fixes xmartlabs#696
  Add support for NSFormatter
  Do validation can be nullable. fixes xmartlabs#705
  fix crash when using cell style Value2. closes xmartlabs#770
  Fix when the textFieldPercentage is applied. Closes xmartlabs#776
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mats-claassen mats-claassen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markrickert @bmichotte @mats-claassen